Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98b22162 authored by Stephen Boyd's avatar Stephen Boyd Committed by Gerrit - the friendly Code Review server
Browse files

pinctrl: qcom: Don't lock around irq_set_irq_wake() 



We don't need to hold the local pinctrl lock here to set irq wake on the
summary irq line. Doing so only leads to lockdep warnings instead of
protecting us from anything. Remove the locking.

Change-Id: I89a9bca1ed4c8aab8b9ecd2000a116c74e33b186
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Git-commit: 1d44616e7549d0154c1224a3eee3c407029294dc
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: default avatarManoj Vishwanathan <mvishwan@codeaurora.org>
parent c5e6208d

drivers/pinctrl/qcom/pinctrl-msm.c

+0 −5
Original line number Diff line number Diff line
@@ -1199,7 +1199,6 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on) 
{

	struct gpio_chip *gc = irq_data_get_irq_chip_data(d);

	struct msm_pinctrl *pctrl = gpiochip_get_data(gc);

	unsigned long flags;



	if (d->parent_data)

		irq_chip_set_wake_parent(d, on);
@@ -1210,12 +1209,8 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on) 
	 * when TLMM is powered on. To allow that, enable the GPIO

	 * summary line to be wakeup capable at GIC.

	 */

	raw_spin_lock_irqsave(&pctrl->lock, flags);



	irq_set_irq_wake(pctrl->irq, on);



	raw_spin_unlock_irqrestore(&pctrl->lock, flags);



	return 0;

}