Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97bf7a19 authored by Thomas Meyer's avatar Thomas Meyer Committed by Ralf Baechle
Browse files

MIPS: ath79: Use kmemdup rather than duplicating its implementation 



The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarGabor Juhos <juhosg@openwrt.org>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/3483/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 36be5051

arch/mips/ath79/dev-gpio-buttons.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -25,12 +25,10 @@ void __init ath79_register_gpio_keys_polled(int id, 
	struct gpio_keys_button *p;

	struct gpio_keys_button *p;

	int err;

	int err;





	p = kmalloc(nbuttons * sizeof(*p), GFP_KERNEL);

	p = kmemdup(buttons, nbuttons * sizeof(*p), GFP_KERNEL);

	if (!p)

	if (!p)

		return;

		return;





	memcpy(p, buttons, nbuttons * sizeof(*p));



	pdev = platform_device_alloc("gpio-keys-polled", id);

	pdev = platform_device_alloc("gpio-keys-polled", id);

	if (!pdev)

	if (!pdev)

		goto err_free_buttons;

		goto err_free_buttons;

arch/mips/ath79/dev-leds-gpio.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -24,12 +24,10 @@ void __init ath79_register_leds_gpio(int id, 
	struct gpio_led *p;

	struct gpio_led *p;

	int err;

	int err;





	p = kmalloc(num_leds * sizeof(*p), GFP_KERNEL);

	p = kmemdup(leds, num_leds * sizeof(*p), GFP_KERNEL);

	if (!p)

	if (!p)

		return;

		return;





	memcpy(p, leds, num_leds * sizeof(*p));



	pdev = platform_device_alloc("leds-gpio", id);

	pdev = platform_device_alloc("leds-gpio", id);

	if (!pdev)

	if (!pdev)

		goto err_free_leds;

		goto err_free_leds;