Commit 95738786 authored Mar 10, 2017 by simran singhal Committed by Greg Kroah-Hartman Mar 12, 2017

staging: atomisp_fops: Clean up tests if NULL returned on failure



Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7cf51d34

drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1100,7 +1100,7 @@ int atomisp_videobuf_mmap_mapper(struct videobuf_queue *q,
	continue;		continue;

	map = kzalloc(sizeof(struct videobuf_mapping), GFP_KERNEL);		map = kzalloc(sizeof(struct videobuf_mapping), GFP_KERNEL);
	if (map == NULL) {		if (!map) {
	mutex_unlock(&q->vb_lock);		mutex_unlock(&q->vb_lock);
	return -ENOMEM;		return -ENOMEM;
	}		}