Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cf51d34 authored by simran singhal's avatar simran singhal Committed by Greg Kroah-Hartman
Browse files

staging: vpfe_mc_capture: Clean up tests if NULL returned on failure 



Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: default avatarsimran singhal <singhalsimran0@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1e8b15d0

drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c

+2 −2
Original line number Diff line number Diff line
@@ -228,7 +228,7 @@ static int vpfe_enable_clock(struct vpfe_device *vpfe_dev) 


	vpfe_dev->clks = kcalloc(vpfe_cfg->num_clocks,

				 sizeof(*vpfe_dev->clks), GFP_KERNEL);

	if (vpfe_dev->clks == NULL)

	if (!vpfe_dev->clks)

		return -ENOMEM;



	for (i = 0; i < vpfe_cfg->num_clocks; i++) {
@@ -348,7 +348,7 @@ static int register_i2c_devices(struct vpfe_device *vpfe_dev) 
	vpfe_dev->sd =

		  kcalloc(num_subdevs, sizeof(struct v4l2_subdev *),

			  GFP_KERNEL);

	if (vpfe_dev->sd == NULL)

	if (!vpfe_dev->sd)

		return -ENOMEM;



	for (i = 0, k = 0; i < num_subdevs; i++) {