Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 93ebc7df authored by Gao Xiang's avatar Gao Xiang Committed by Michael Bestas
Browse files

erofs: don't trigger WARN() when decompression fails 

[ Upstream commit a0961f351d82d43ab0b845304caa235dfe249ae9 ]

syzbot reported a WARNING [1] due to corrupted compressed data.

As Dmitry said, "If this is not a kernel bug, then the code should
not use WARN. WARN if for kernel bugs and is recognized as such by
all testing systems and humans."

[1] https://lore.kernel.org/r/000000000000b3586105cf0ff45e@google.com

Link: https://lore.kernel.org/r/20211025074311.130395-1-hsiangkao@linux.alibaba.com


Cc: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Reported-by: default avatar <syzbot+d8aaffc3719597e8cfb4@syzkaller.appspotmail.com>
Change-Id: Iabf98450c13059e71bc859f7013a811ce359ddec
Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 74a9822f

fs/erofs/decompressor.c

+0 −1
Original line number Diff line number Diff line
@@ -174,7 +174,6 @@ static int z_erofs_lz4_decompress(struct z_erofs_decompress_req *rq, u8 *out) 
		erofs_err(rq->sb, "failed to decompress %d in[%u, %u] out[%u]",

			  ret, inlen, inputmargin, rq->outputsize);



		WARN_ON(1);

		print_hex_dump(KERN_DEBUG, "[ in]: ", DUMP_PREFIX_OFFSET,

			       16, 1, src + inputmargin, inlen, true);

		print_hex_dump(KERN_DEBUG, "[out]: ", DUMP_PREFIX_OFFSET,