Unverified Commit 74a9822f authored May 19, 2021 by Wei Yongjun Committed by Michael Bestas Apr 16, 2024

erofs: fix error return code in erofs_read_superblock()

commit 0508c1ad0f264a24c4643701823a45f6c9bd8146 upstream.

'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true,
thus 0 will return in some error handling cases. Fix to return negative
error code -EINVAL instead of 0.

Link: https://lore.kernel.org/r/20210519141657.3062715-1-weiyongjun1@huawei.com


Fixes: b858a4844cfb ("erofs: support superblock checksum")
Cc: stable <stable@vger.kernel.org> # 5.5+
Reported-by: Hulk Robot <hulkci@huawei.com>
Change-Id: Ic4ca54cc51b12e814dfc44b569e4bbe354a6e8f7
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Gao Xiang <xiang@kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <xiang@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d0d2e8ba

fs/erofs/super.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -155,6 +155,7 @@ static int erofs_read_superblock(struct super_block *sb)
		goto out;
		}

		ret = -EINVAL;
		blkszbits = dsb->blkszbits;
		/* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */
		if (blkszbits != LOG_BLOCK_SIZE) {