Commit 93a36876 authored Jul 15, 2020 by Raghavendra Rao Ananta

soc: qcom: pil: Handle uninitialized 'ret'

The commit <a0a9abc9> (pil: Fix minidump collection during
SSR) failed to set the value of 'ret' in pil_do_minidump() upon
the return failure from prepare_minidump_segments(). As a result,
the 'goto seg_mapping_fail' will end up returning uninitialized
value. Hence, assign an error code explicitly to avoid this situation.

Change-Id: I20f0d2c4fd006483c73541937025ed50b265e2b4
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>

parent 9e1aed8f

drivers/soc/qcom/peripheral-loader.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -398,8 +398,10 @@ static int pil_do_minidump(struct pil_desc desc, void ramdump_dev)
		next_offset = prepare_minidump_segments(ramdump_segs, region_info_ss,
		ss_mdump_seg_cnt_ss,
		&ss_valid_seg_cnt);
		if (next_offset < 0)
		if (next_offset < 0) {
		ret = -ENOMEM;
		goto seg_mapping_fail;
		}

		if (desc->num_aux_minidump_ids > 0) {
		ret = prepare_aux_minidump_segments(&ramdump_segs[next_offset],