Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8de1b23e authored by Tvrtko Ursulin's avatar Tvrtko Ursulin
Browse files

drm/i915/lrc: Do not wait atomically when stopping engines 



I do not see that this needs to be done atomically and up to
one second is quite a long time to busy loop.

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 3f177625

drivers/gpu/drm/i915/intel_lrc.c

+1 −1
Original line number Diff line number Diff line
@@ -1062,7 +1062,7 @@ void intel_logical_ring_stop(struct intel_engine_cs *ring) 


	/* TODO: Is this correct with Execlists enabled? */

	I915_WRITE_MODE(ring, _MASKED_BIT_ENABLE(STOP_RING));

	if (wait_for_atomic((I915_READ_MODE(ring) & MODE_IDLE) != 0, 1000)) {

	if (wait_for((I915_READ_MODE(ring) & MODE_IDLE) != 0, 1000)) {

		DRM_ERROR("%s :timed out trying to stop ring\n", ring->name);

		return;

	}