Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8db420ac authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/todo: Improve drm_gem_object funcs todo



We're kinda going in the wrong direction. Spotted while typing better
gem/prime docs.

Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Acked-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190614203615.12639-2-daniel.vetter@ffwll.ch
parent f5500f38
Loading
Loading
Loading
Loading
+4 −0
Original line number Diff line number Diff line
@@ -228,6 +228,10 @@ struct drm_gem_object_funcs
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.

Unfortunately some of the recently added GEM helpers are going in the wrong
direction by adding OPS macros that use the old, deprecated hooks. See
DRM_GEM_CMA_VMAP_DRIVER_OPS, DRM_GEM_SHMEM_DRIVER_OPS, and DRM_GEM_VRAM_DRIVER_PRIME.

Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
---------------------------------------------------------