Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87cade29 authored by Eran Ben Elisha's avatar Eran Ben Elisha Committed by David S. Miller
Browse files

net/mlx5: Fix return code in case of hyperv wrong size read 



Return code value could be non deterministic in case of wrong size read.
With this patch, if such error occurs, set rc to be -EIO.

In addition, mlx5_hv_config_common() supports reading of
HV_CONFIG_BLOCK_SIZE_MAX bytes only, fix to early return error with
bad input.

Fixes: 913d14e8 ("net/mlx5: Add wrappers for HyperV PCIe operations")
Reported-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7a42eb4

drivers/net/ethernet/mellanox/mlx5/core/lib/hv.c

+3 −3
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ static int mlx5_hv_config_common(struct mlx5_core_dev *dev, void *buf, int len, 
	int bytes_returned;

	int block_id;



	if (offset % HV_CONFIG_BLOCK_SIZE_MAX || len % HV_CONFIG_BLOCK_SIZE_MAX)

	if (offset % HV_CONFIG_BLOCK_SIZE_MAX || len != HV_CONFIG_BLOCK_SIZE_MAX)

		return -EINVAL;



	block_id = offset / HV_CONFIG_BLOCK_SIZE_MAX;
@@ -25,8 +25,8 @@ static int mlx5_hv_config_common(struct mlx5_core_dev *dev, void *buf, int len, 
				  HV_CONFIG_BLOCK_SIZE_MAX, block_id);



	/* Make sure len bytes were read successfully  */

	if (read)

		rc |= !(len == bytes_returned);

	if (read && !rc && len != bytes_returned)

		rc = -EIO;



	if (rc) {

		mlx5_core_err(dev, "Failed to %s hv config, err = %d, len = %d, offset = %d\n",