Commit 809aa504 authored May 09, 2007 by James Bottomley Committed by Linus Torvalds May 09, 2007

mca: fix bus matching



There's a bug in the MCA bus matching algorithm in that it promotes from
signed short to int before comparing with the actual id and does sign
extension on anything > 0x7fff (which means that pos ids > 0x7fff never get
correctly matched).

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 818563dc

drivers/mca/mca-bus.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -47,7 +47,7 @@ static int mca_bus_match (struct device dev, struct device_driver drv)
		{
		struct mca_device *mca_dev = to_mca_device (dev);
		struct mca_driver *mca_drv = to_mca_driver (drv);
		const short *mca_ids = mca_drv->id_table;
		const unsigned short *mca_ids = mca_drv->id_table;
		int i;

		if (!mca_ids)