Commit 8034fc4e authored Jun 01, 2021 by Jiapeng Chong Committed by Greg Kroah-Hartman Jun 18, 2021

ethernet: myri10ge: Fix missing error code in myri10ge_probe()



[ Upstream commit f336d0b93ae978f12c5e27199f828da89b91e56a ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'status'.

Eliminate the follow smatch warning:

drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe()
warn: missing error code 'status'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ea4a9a34

drivers/net/ethernet/myricom/myri10ge/myri10ge.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3849,6 +3849,7 @@ static int myri10ge_probe(struct pci_dev pdev, const struct pci_device_id ent)
		dev_err(&pdev->dev,
		"invalid sram_size %dB or board span %ldB\n",
		mgp->sram_size, mgp->board_span);
		status = -EINVAL;
		goto abort_with_ioremap;
		}
		memcpy_fromio(mgp->eeprom_strings,