Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fdb5cea authored by Bob Moore's avatar Bob Moore Committed by Rafael J. Wysocki
Browse files

ACPICA: Interpreter: Remove temporary code for External() opcode 

ACPICA commit f2d349f8a11efc0f438ad6903564f3a6755dc6b9

The interpreter should never see this opcode (it is used by
disassemblers), so the final implementation is to return an
error.

Link: https://github.com/acpica/acpica/commit/f2d349f8


Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent fee4ab9c

drivers/acpi/acpica/dsutils.c

+8 −9
Original line number Diff line number Diff line
@@ -565,15 +565,14 @@ acpi_ds_create_operand(struct acpi_walk_state *walk_state, 
					status = AE_OK;

				} else if (parent_op->common.aml_opcode ==

					   AML_EXTERNAL_OP) {



					/* TBD: May only be temporary */



					obj_desc =

					    acpi_ut_create_string_object((acpi_size)name_length);



					strncpy(obj_desc->string.pointer,

						name_string, name_length);

					status = AE_OK;

					/*

					 * This opcode should never appear here. It is used only

					 * by AML disassemblers and is surrounded by an If(0)

					 * by the ASL compiler.

					 *

					 * Therefore, if we see it here, it is a serious error.

					 */

					status = AE_AML_BAD_OPCODE;

				} else {

					/*

					 * We just plain didn't find it -- which is a