Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bb35d66 authored by Jeya R's avatar Jeya R Committed by Gerrit - the friendly Code Review server
Browse files

msm: ADSPRPC: Size check before allocating memory from DMA 



For allocating memory from DMA we need to do a size check.
This validation is required to avoid any improper paging
request. We already have the range in which the size is
expected to be.

Change-Id: I20a843366a7f3e3e21cef89cf1ea5bec3f93ab2d
Acked-by: default avatarEkansh Gupta <ekangupt@qti.qualcomm.com>
Signed-off-by: default avatarJeya R <jeyr@codeaurora.org>
parent 227e7597

drivers/char/adsprpc.c

+8 −0
Original line number Diff line number Diff line
@@ -909,6 +909,7 @@ static int fastrpc_mmap_find(struct fastrpc_file *fl, int fd, 
static int fastrpc_alloc_cma_memory(dma_addr_t *region_phys, void **vaddr,

				size_t size, unsigned long dma_attr)

{

	int err = 0;

	struct fastrpc_apps *me = &gfa;



	if (me->dev == NULL) {
@@ -916,6 +917,13 @@ static int fastrpc_alloc_cma_memory(dma_addr_t *region_phys, void **vaddr, 
			"failed to allocate CMA memory, device adsprpc-mem is not initialized\n");

		return -ENODEV;

	}

	VERIFY(err, size > 0 && size < me->max_size_limit);

	if (err) {

		err = -EFAULT;

		pr_err("adsprpc: %s: invalid allocation size 0x%zx\n",

			__func__, size);

		return err;

	}

	*vaddr = dma_alloc_attrs(me->dev, size, region_phys,

					GFP_KERNEL, dma_attr);

	if (IS_ERR_OR_NULL(*vaddr)) {