Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f219891 authored by Xiu Jianfeng's avatar Xiu Jianfeng Committed by Greg Kroah-Hartman
Browse files

clk: socfpga: Fix memory leak in socfpga_gate_init() 



[ Upstream commit 0b8ba891ad4d1ef6bfa4c72efc83f9f9f855f68b ]

Free @socfpga_clk and @ops on the error path to avoid memory leak issue.

Fixes: a30a67be ("clk: socfpga: Don't have get_parent for single parent ops")
Signed-off-by: default avatarXiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221123031622.63171-1-xiujianfeng@huawei.com


Acked-by: default avatarDinh Nguyen <dinguyen@kernel.org>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent dbd1a4fd

drivers/clk/socfpga/clk-gate.c

+4 −1
Original line number Original line Diff line number Diff line
@@ -188,8 +188,10 @@ void __init socfpga_gate_init(struct device_node *node) 
		return;

		return;





	ops = kmemdup(&gateclk_ops, sizeof(gateclk_ops), GFP_KERNEL);

	ops = kmemdup(&gateclk_ops, sizeof(gateclk_ops), GFP_KERNEL);

	if (WARN_ON(!ops))

	if (WARN_ON(!ops)) {

		kfree(socfpga_clk);

		return;

		return;

	}





	rc = of_property_read_u32_array(node, "clk-gate", clk_gate, 2);

	rc = of_property_read_u32_array(node, "clk-gate", clk_gate, 2);

	if (rc)

	if (rc)
@@ -243,6 +245,7 @@ void __init socfpga_gate_init(struct device_node *node) 




	err = clk_hw_register(NULL, hw_clk);

	err = clk_hw_register(NULL, hw_clk);

	if (err) {

	if (err) {

		kfree(ops);

		kfree(socfpga_clk);

		kfree(socfpga_clk);

		return;

		return;

	}

	}