Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e0b8d96 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Greg Kroah-Hartman
Browse files

ALSA: firewire-motu: drop EPOLLOUT from poll return values as write is not supported 



[ Upstream commit aea3493246c474bc917d124d6fb627663ab6bef0 ]

The ALSA HwDep character device of the firewire-motu driver incorrectly
returns EPOLLOUT in poll(2), even though the driver implements no operation
for write(2). This misleads userspace applications to believe write() is
allowed, potentially resulting in unnecessarily wakeups.

This issue dates back to the driver's initial code added by a commit
71c37977 ("ALSA: firewire-motu: add hwdep interface"), and persisted
when POLLOUT was updated to EPOLLOUT by a commit a9a08845 ('vfs: do
bulk POLL* -> EPOLL* replacement("").').

This commit fixes the bug.

Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://patch.msgid.link/20250829233749.366222-1-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 8e01ea18

sound/firewire/motu/motu-hwdep.c

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ static __poll_t hwdep_poll(struct snd_hwdep *hwdep, struct file *file, 
		events = 0;

	spin_unlock_irq(&motu->lock);



	return events | EPOLLOUT;

	return events;

}



static int hwdep_get_info(struct snd_motu *motu, void __user *arg)