Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d4fab39 authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: Reset net device with rtnl_lock 



Since current locking was not covering certain code where
netdev was being accessed or manipulated, this patch fixes
it.

Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1b372578

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+2 −3
Original line number Diff line number Diff line
@@ -2820,15 +2820,13 @@ static void hclge_clear_reset_cause(struct hclge_dev *hdev) 
static void hclge_reset(struct hclge_dev *hdev)

{

	/* perform reset of the stack & ae device for a client */



	rtnl_lock();

	hclge_notify_client(hdev, HNAE3_DOWN_CLIENT);



	if (!hclge_reset_wait(hdev)) {

		rtnl_lock();

		hclge_notify_client(hdev, HNAE3_UNINIT_CLIENT);

		hclge_reset_ae_dev(hdev->ae_dev);

		hclge_notify_client(hdev, HNAE3_INIT_CLIENT);

		rtnl_unlock();



		hclge_clear_reset_cause(hdev);

	} else {
@@ -2838,6 +2836,7 @@ static void hclge_reset(struct hclge_dev *hdev) 
	}



	hclge_notify_client(hdev, HNAE3_UP_CLIENT);

	rtnl_unlock();

}



static void hclge_reset_event(struct hnae3_handle *handle)