Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d1f3732 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Kalle Valo
Browse files

wcn36xx: Reduce spinlock in indication handler 



The purpose of pushing indication on a list and handle these in a
separate worker is to allow the handlers to sleep. It does therefor not
make much sense to hold the queue spinlock through the entire indication
worker function.

By removing items from the queue early we don't need to hold the lock
throughout the indication worker, allowing the individual handlers to
sleep.

Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 413fd2f5

drivers/net/wireless/ath/wcn36xx/smd.c

+2 −2
Original line number Diff line number Diff line
@@ -2416,6 +2416,8 @@ static void wcn36xx_ind_smd_work(struct work_struct *work) 
	hal_ind_msg = list_first_entry(&wcn->hal_ind_queue,

				       struct wcn36xx_hal_ind_msg,

				       list);

	list_del(wcn->hal_ind_queue.next);

	spin_unlock_irqrestore(&wcn->hal_ind_lock, flags);



	msg_header = (struct wcn36xx_hal_msg_header *)hal_ind_msg->msg;
@@ -2452,8 +2454,6 @@ static void wcn36xx_ind_smd_work(struct work_struct *work) 
		wcn36xx_err("SMD_EVENT (%d) not supported\n",

			      msg_header->msg_type);

	}

	list_del(wcn->hal_ind_queue.next);

	spin_unlock_irqrestore(&wcn->hal_ind_lock, flags);

	kfree(hal_ind_msg);

}

int wcn36xx_smd_open(struct wcn36xx *wcn)