Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 413fd2f5 authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

ath9k_htc: Add a sanity check in ath9k_htc_ampdu_action() 



Smatch generates a warning here:

    drivers/net/wireless/ath/ath9k/htc_drv_main.c:1688 ath9k_htc_ampdu_action()
    error: buffer overflow 'ista->tid_state' 8 <= 15

I don't know if it's a real bug or not but the other paths through this
function all ensure that "tid" is less than ATH9K_HTC_MAX_TID (8) so
checking here makes things more consistent.

Fixes: fb9987d0 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 2f3bef4b

drivers/net/wireless/ath/ath9k/htc_drv_main.c

+4 −0
Original line number Diff line number Diff line
@@ -1683,6 +1683,10 @@ static int ath9k_htc_ampdu_action(struct ieee80211_hw *hw, 
		ieee80211_stop_tx_ba_cb_irqsafe(vif, sta->addr, tid);

		break;

	case IEEE80211_AMPDU_TX_OPERATIONAL:

		if (tid >= ATH9K_HTC_MAX_TID) {

			ret = -EINVAL;

			break;

		}

		ista = (struct ath9k_htc_sta *) sta->drv_priv;

		spin_lock_bh(&priv->tx.tx_lock);

		ista->tid_state[tid] = AGGR_OPERATIONAL;