Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67d41894 authored by Vinay Sudra's avatar Vinay Sudra
Browse files

msm: adsprpc: Fix build issue due to casting from large to small type 



Fix compilation issue while Casting a large number type to a smaller type
which may lead to data lost.

Replace ‘null’ with ‘0’ as null is 64bit wide.

Change-Id: Ic77dfac7c920cf3dbdfe459ec435680cb69be2f5
Signed-off-by: default avatarVinay Sudra <vsudra@codeaurora.org>
parent 75241994

drivers/char/adsprpc_compat.c

+4 −4
Original line number Diff line number Diff line
@@ -295,8 +295,8 @@ static int compat_get_fastrpc_ioctl_invoke( 
		err |= get_user(p, &inv32->job);

		err |= put_user(p, (compat_uptr_t __user *)&inv->job);

	}

	err |= put_user((compat_uptr_t)NULL, (compat_uptr_t __user *)&inv->perf_kernel);

	err |= put_user((compat_uptr_t)NULL, (compat_uptr_t __user *)&inv->perf_dsp);

	err |= put_user((compat_uptr_t)0, (compat_uptr_t __user *)&inv->perf_kernel);

	err |= put_user((compat_uptr_t)0, (compat_uptr_t __user *)&inv->perf_dsp);

	if ((cmd == COMPAT_FASTRPC_IOCTL_INVOKE_PERF) || (cmd == FASTRPC_INVOKE2_ASYNC)) {

		err |= get_user(k, &inv32->perf_kernel);

		err |= get_user(p, &inv32->perf_dsp);
@@ -384,9 +384,9 @@ static int compat_get_fastrpc_ioctl_invoke2( 
			err |= put_user(NULL, &asyncinv_user->job);

			err |= get_user(p, &lasync32_old->job);

			err |= put_user(p, (compat_uptr_t __user *)&asyncinv_user->job);

			err |= put_user((compat_uptr_t)NULL,

			err |= put_user((compat_uptr_t)0,

				(compat_uptr_t __user *)&asyncinv_user->perf_kernel);

			err |= put_user((compat_uptr_t)NULL,

			err |= put_user((compat_uptr_t)0,

				(compat_uptr_t __user *)&asyncinv_user->perf_dsp);

		} else {

			VERIFY(err, 0 == compat_get_fastrpc_ioctl_invoke(lasync32,