Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62a9d9fc authored by Yunfeng Ye's avatar Yunfeng Ye Committed by Herbert Xu
Browse files

crypto: hisilicon - Fix return value check in hisi_zip_acompress() 



The return valude of add_comp_head() is int, but @head_size is size_t,
which is a unsigned type.

	size_t head_size;
	...
	if (head_size < 0)  // it will never work
		return -ENOMEM

Modify the type of @head_size to int, then change the type to size_t
when invoke hisi_zip_create_req() as a parameter.

Fixes: 62c455ca ("crypto: hisilicon - add HiSilicon ZIP accelerator support")
Signed-off-by: default avatarYunfeng Ye <yeyunfeng@huawei.com>
Acked-by: default avatarZhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e00371af

drivers/crypto/hisilicon/zip/zip_crypto.c

+2 −2
Original line number Diff line number Diff line
@@ -559,7 +559,7 @@ static int hisi_zip_acompress(struct acomp_req *acomp_req) 
	struct hisi_zip_ctx *ctx = crypto_tfm_ctx(acomp_req->base.tfm);

	struct hisi_zip_qp_ctx *qp_ctx = &ctx->qp_ctx[QPC_COMP];

	struct hisi_zip_req *req;

	size_t head_size;

	int head_size;

	int ret;



	/* let's output compression head now */
@@ -567,7 +567,7 @@ static int hisi_zip_acompress(struct acomp_req *acomp_req) 
	if (head_size < 0)

		return -ENOMEM;



	req = hisi_zip_create_req(acomp_req, qp_ctx, head_size, true);

	req = hisi_zip_create_req(acomp_req, qp_ctx, (size_t)head_size, true);

	if (IS_ERR(req))

		return PTR_ERR(req);