Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60584ba9 authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Greg Kroah-Hartman
Browse files

ntb: use 64-bit arithmetic for the MSI doorbell mask 



commit fd5625fc86922f36bedee5846fefd647b7e72751 upstream.

msi_db_mask is of type 'u64', still the standard 'int' arithmetic is
performed to compute its value.

While most of the ntb_hw drivers actually don't utilize the higher 32
bits of the doorbell mask now, this may be the case for Switchtec - see
switchtec_ntb_init_db().

Found by Linux Verification Center (linuxtesting.org) with SVACE static
analysis tool.

Fixes: 2b0569b3 ("NTB: Add MSI interrupt support to ntb_transport")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Signed-off-by: default avatarJon Mason <jdmason@kudzu.us>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 34c4feb0

drivers/ntb/ntb_transport.c

+1 −1
Original line number Diff line number Diff line
@@ -1340,7 +1340,7 @@ static int ntb_transport_probe(struct ntb_client *self, struct ntb_dev *ndev) 
	qp_count = ilog2(qp_bitmap);

	if (nt->use_msi) {

		qp_count -= 1;

		nt->msi_db_mask = 1 << qp_count;

		nt->msi_db_mask = BIT_ULL(qp_count);

		ntb_db_clear_mask(ndev, nt->msi_db_mask);

	}