Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d65f918 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] fnic: potential dead lock in fnic_is_abts_pending() 



There is an unlock missing if the == FNIC_IOREQ_ABTS_PENDING is
false.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarHiral Patel <hiralpat@cisco.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 607be2cf

drivers/scsi/fnic/fnic_scsi.c

+2 −4
Original line number Diff line number Diff line
@@ -2432,11 +2432,9 @@ int fnic_is_abts_pending(struct fnic *fnic, struct scsi_cmnd *lr_sc) 
			      "Found IO in %s on lun\n",

			      fnic_ioreq_state_to_str(CMD_STATE(sc)));



		if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING) {

			spin_unlock_irqrestore(io_lock, flags);

		if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING)

			ret = 1;

			continue;

		}

		spin_unlock_irqrestore(io_lock, flags);

	}



	return ret;