comedi: das16m1: Fix bit shift out of bounds
commit ed93c6f68a3be06e4e0c331c6e751f462dee3932 upstream. When checking for a supported IRQ number, the following test is used: /* only irqs 2, 3, 4, 5, 6, 7, 10, 11, 12, 14, and 15 are valid */ if ((1 << it->options[1]) & 0xdcfc) { However, `it->options[i]` is an unchecked `int` value from userspace, so the shift amount could be negative or out of bounds. Fix the test by requiring `it->options[1]` to be within bounds before proceeding with the original test. Reported-by:<syzbot+c52293513298e0fd9a94@syzkaller.appspotmail.com> Closes: https://syzkaller.appspot.com/bug?extid=c52293513298e0fd9a94 Fixes: 72998850 ("staging: comedi: das16m1: tidy up the irq support in das16m1_attach()") Tested-by:
<syzbot+c52293513298e0fd9a94@syzkaller.appspotmail.com> Suggested-by:
"Enju, Kohei" <enjuk@amazon.co.jp> Cc: stable@vger.kernel.org # 5.13+ Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/20250707130908.70758-1-abbotti@mev.co.uk Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Loading
Please register or sign in to comment