Commit 50be644f authored Jul 19, 2022 by Liang He Committed by Greg Kroah-Hartman Aug 25, 2022

iommu/arm-smmu: qcom_iommu: Add of_node_put() when breaking out of loop



[ Upstream commit a91eb6803c1c715738682fece095145cbd68fe0b ]

In qcom_iommu_has_secure_context(), we should call of_node_put()
for the reference 'child' when breaking out of for_each_child_of_node()
which will automatically increase and decrease the refcount.

Fixes: d051f28c ("iommu/qcom: Initialize secure page table")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220719124955.1242171-1-windhl@126.com


Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b948ff8a

drivers/iommu/qcom_iommu.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -785,9 +785,12 @@ static bool qcom_iommu_has_secure_context(struct qcom_iommu_dev *qcom_iommu)
		{
		struct device_node *child;

		for_each_child_of_node(qcom_iommu->dev->of_node, child)
		if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec"))
		for_each_child_of_node(qcom_iommu->dev->of_node, child) {
		if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec")) {
		of_node_put(child);
		return true;
		}
		}

		return false;
		}