Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 508a6c80 authored by Elliot Berman's avatar Elliot Berman Committed by Gerrit - the friendly Code Review server
Browse files

checkpatch: Handle quotes within commit reference descriptions



Checkpatch tests that commit references follow the format:

  commit 19c146a6 ("checkpatch: make sure a commit reference
description uses parentheses")

If a commit is a revert commit, its title line is frequently like:
  Revert "checkpatch: make sure a commit reference uses parantheses"

Checkpatch doesn't handle quotation marks in commit message properly, so
use a lookahead to detect the "), which is less frequently found in
commit message title lines. Since a lookahead is used, commits with ")
in the title line, such as commit 8ac68dc455d9 ("revert: 1320a4052ea1
("audit: trigger accompanying records when no rules present")"), is
handled properly.

There is at least one case not properly handled, where the title spans
two lines and there is a ") on the first line. There are approximately 5
such possible commits on 5.9-rc8.

Change-Id: Ia3355103aa6d15d4109fa11155d07b14bd7d9f0f
Signed-off-by: default avatarElliot Berman <eberman@codeaurora.org>
parent b20ec664
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment