Commit 4e4e6ca6 authored Sep 20, 2022 by Ricardo Ribalda Committed by Greg Kroah-Hartman Mar 11, 2023

media: uvcvideo: Handle cameras with invalid descriptors



[ Upstream commit 41ddb251c68ac75c101d3a50a68c4629c9055e4c ]

If the source entity does not contain any pads, do not create a link.

Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7195e642

drivers/media/usb/uvc/uvc_entity.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -37,7 +37,7 @@ static int uvc_mc_create_links(struct uvc_video_chain *chain,
		continue;

		remote = uvc_entity_by_id(chain->dev, entity->baSourceID[i]);
		if (remote == NULL)
		if (remote == NULL \|\| remote->num_pads == 0)
		return -EINVAL;

		source = (UVC_ENTITY_TYPE(remote) == UVC_TT_STREAMING)