Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7195e642 authored by Liang He's avatar Liang He Committed by Greg Kroah-Hartman
Browse files

mfd: arizona: Use pm_runtime_resume_and_get() to prevent refcnt leak 



[ Upstream commit 4414a7ab80cebf715045e3c4d465feefbad21139 ]

In arizona_clk32k_enable(), we should use pm_runtime_resume_and_get()
as pm_runtime_get_sync() will increase the refcnt even when it
returns an error.

Signed-off-by: default avatarLiang He <windhl@126.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230105061055.1509261-1-windhl@126.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent fde59e27

drivers/mfd/arizona-core.c

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ int arizona_clk32k_enable(struct arizona *arizona) 
	if (arizona->clk32k_ref == 1) {

		switch (arizona->pdata.clk32k_src) {

		case ARIZONA_32KZ_MCLK1:

			ret = pm_runtime_get_sync(arizona->dev);

			ret = pm_runtime_resume_and_get(arizona->dev);

			if (ret != 0)

				goto err_ref;

			ret = clk_prepare_enable(arizona->mclk[ARIZONA_MCLK1]);