Commit 4db0a85c authored Jul 17, 2023 by Geert Uytterhoeven Committed by Greg Kroah-Hartman Sep 23, 2023

drm/armada: Fix off-by-one error in armada_overlay_get_property()



[ Upstream commit 5f0d984053f74983a287100a9519b2fabb785fb5 ]

As ffs() returns one more than the index of the first bit set (zero
means no bits set), the color key mode value is shifted one position too
much.

Fix this by using FIELD_GET() instead.

Fixes: c96103b6 ("drm/armada: move colorkey properties into overlay plane state")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/a4d779d954a7515ddbbf31cb0f0d8184c0e7c879.1689600265.git.geert+renesas@glider.be


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent dadf0d0d

drivers/gpu/drm/armada/armada_overlay.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -4,6 +4,8 @@
		* Rewritten from the dovefb driver, and Armada510 manuals.
		*/

		#include <linux/bitfield.h>

		#include <drm/armada_drm.h>
		#include <drm/drm_atomic.h>
		#include <drm/drm_atomic_helper.h>
		@@ -446,8 +448,8 @@ static int armada_overlay_get_property(struct drm_plane *plane,
		drm_to_overlay_state(state)->colorkey_ug,
		drm_to_overlay_state(state)->colorkey_vb, 0);
		} else if (property == priv->colorkey_mode_prop) {
		*val = (drm_to_overlay_state(state)->colorkey_mode &
		CFG_CKMODE_MASK) >> ffs(CFG_CKMODE_MASK);
		*val = FIELD_GET(CFG_CKMODE_MASK,
		drm_to_overlay_state(state)->colorkey_mode);
		} else if (property == priv->brightness_prop) {
		*val = drm_to_overlay_state(state)->brightness + 256;
		} else if (property == priv->contrast_prop) {