Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ce30874 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by James Bottomley
Browse files

iscsi: Fix iscsi endpoints leak 



When creating a new endpoint, we look for a free id
for the new endpoint. We baisically loop on possible ids
and use the first id that class_find_device() returns NULL.
However, we are missing a reference put when class_find_device()
does find an existing device for a given id.

Reported-by: default avatarAlex Lyakas <alex@zadarastorage.com>
Signed-off-by: default avatarSagi Grimberg <sagig@mellanox.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent e03c2da6

drivers/scsi/scsi_transport_iscsi.c

+2 −0
Original line number Diff line number Diff line
@@ -204,6 +204,8 @@ iscsi_create_endpoint(int dd_size) 
					iscsi_match_epid);

		if (!dev)

			break;

		else

			put_device(dev);

	}

	if (id == ISCSI_MAX_EPID) {

		printk(KERN_ERR "Too many connections. Max supported %u\n",