Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e03c2da6 authored by James Bottomley's avatar James Bottomley
Browse files

ips: remove pointless #warning 



non-x86 builds want the #warning in the IPS code about compiling on the wrong
architecture removed because it keeps triggering on their platforms build
farms.  Transform from a compile time warning into a runtime one with taint to
preserve the original intent of the authors.

Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent 35843048

drivers/scsi/ips.c

+5 −4
Original line number Diff line number Diff line
@@ -206,10 +206,6 @@ module_param(ips, charp, 0); 
#define IPS_VERSION_HIGH        IPS_VER_MAJOR_STRING "." IPS_VER_MINOR_STRING

#define IPS_VERSION_LOW         "." IPS_VER_BUILD_STRING " "



#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__)

#warning "This driver has only been tested on the x86/ia64/x86_64 platforms"

#endif



#define IPS_DMA_DIR(scb) ((!scb->scsi_cmd || ips_is_passthru(scb->scsi_cmd) || \

                         DMA_NONE == scb->scsi_cmd->sc_data_direction) ? \

                         PCI_DMA_BIDIRECTIONAL : \
@@ -6788,6 +6784,11 @@ ips_remove_device(struct pci_dev *pci_dev) 
static int __init

ips_module_init(void)

{

#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__)

	printk(KERN_ERR "ips: This driver has only been tested on the x86/ia64/x86_64 platforms\n");

	add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK);

#endif



	if (pci_register_driver(&ips_pci_driver) < 0)

		return -ENODEV;

	ips_driver_template.module = THIS_MODULE;