Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4cb29f25 authored by Vincent Mailhol's avatar Vincent Mailhol Committed by Greg Kroah-Hartman
Browse files

can: pch_can: do not report txerr and rxerr during bus-off 

[ Upstream commit 3a5c7e4611ddcf0ef37a3a17296b964d986161a6 ]

During bus off, the error count is greater than 255 and can not fit in
a u8.

Fixes: 0c78ab76 ("pch_can: Add setting TEC/REC statistics processing")
Link: https://lore.kernel.org/all/20220719143550.3681-2-mailhol.vincent@wanadoo.fr


Signed-off-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ecbdb298

drivers/net/can/pch_can.c

+3 −3
Original line number Diff line number Diff line
@@ -496,6 +496,9 @@ static void pch_can_error(struct net_device *ndev, u32 status) 
		cf->can_id |= CAN_ERR_BUSOFF;

		priv->can.can_stats.bus_off++;

		can_bus_off(ndev);

	} else {

		cf->data[6] = errc & PCH_TEC;

		cf->data[7] = (errc & PCH_REC) >> 8;

	}



	errc = ioread32(&priv->regs->errc);
@@ -556,9 +559,6 @@ static void pch_can_error(struct net_device *ndev, u32 status) 
		break;

	}



	cf->data[6] = errc & PCH_TEC;

	cf->data[7] = (errc & PCH_REC) >> 8;



	priv->can.state = state;

	netif_receive_skb(skb);