Commit ecbdb298 authored Jul 19, 2022 by Dan Carpenter Committed by Greg Kroah-Hartman Aug 25, 2022

selftests/bpf: fix a test for snprintf() overflow



[ Upstream commit c5d22f4cfe8dfb93f1db0a1e7e2e7ebc41395d98 ]

The snprintf() function returns the number of bytes which *would*
have been copied if there were space.  In other words, it can be
> sizeof(pin_path).

Fixes: c0fa1b6c ("bpf: btf: Add BTF tests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/r/YtZ+aD/tZMkgOUw+@kili


Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e134d998

tools/testing/selftests/bpf/test_btf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4808,7 +4808,7 @@ static int do_test_pprint(int test_num)
		ret = snprintf(pin_path, sizeof(pin_path), "%s/%s",
		"/sys/fs/bpf", test->map_name);

		if (CHECK(ret == sizeof(pin_path), "pin_path %s/%s is too long",
		if (CHECK(ret >= sizeof(pin_path), "pin_path %s/%s is too long",
		"/sys/fs/bpf", test->map_name)) {
		err = -1;
		goto done;