Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 49e73720 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd: fh_update should error out in unexpected cases



The reporter saw a NULL dereference when a filesystem's ->mknod returned
success but left the dentry negative, and then nfsd tried to dereference
d_inode (in this case because the CREATE was followed by a GETATTR in
the same nfsv4 compound).

fh_update already checks for this and another broken case, but for some
reason it returns success and leaves nfsd trying to soldier on.  If it
failed we'd avoid the crash.  There's only so much we can do with a
buggy filesystem, but it's easy enough to bail out here, so let's do
that.

Reported-by: default avatarAntti Tönkyrä <daedalus@pingtimeout.net>
Tested-by: default avatarAntti Tönkyrä <daedalus@pingtimeout.net>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 956c4fee
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment