Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 436018ee authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Marcel Holtmann
Browse files

bluetooth: btmrvl_sdio: Replace GFP_ATOMIC with GFP_KERNEL in btmrvl_sdio_card_to_host() 



btmrvl_sdio_card_to_host() is never called in atomic context.
It calls bt_skb_alloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 478113e4

drivers/bluetooth/btmrvl_sdio.c

+1 −1
Original line number Diff line number Diff line
@@ -718,7 +718,7 @@ static int btmrvl_sdio_card_to_host(struct btmrvl_private *priv) 
	}



	/* Allocate buffer */

	skb = bt_skb_alloc(num_blocks * blksz + BTSDIO_DMA_ALIGN, GFP_ATOMIC);

	skb = bt_skb_alloc(num_blocks * blksz + BTSDIO_DMA_ALIGN, GFP_KERNEL);

	if (!skb) {

		BT_ERR("No free skb");

		ret = -ENOMEM;