Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 478113e4 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Marcel Holtmann
Browse files

bluetooth: bpa10x: Replace GFP_ATOMIC with GFP_KERNEL in bpa10x_send_frame() 



bpa10x_send_frame() is only set to hdev->send, and hdev->send() is never
called in atomic context.

bpa10x_send_frame() calls usb_alloc_urb(), kmalloc() and usb_submit_urb()
with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 5f9c6580

drivers/bluetooth/bpa10x.c

+3 −3
Original line number Diff line number Diff line
@@ -289,7 +289,7 @@ static int bpa10x_send_frame(struct hci_dev *hdev, struct sk_buff *skb) 


	skb->dev = (void *) hdev;



	urb = usb_alloc_urb(0, GFP_ATOMIC);

	urb = usb_alloc_urb(0, GFP_KERNEL);

	if (!urb)

		return -ENOMEM;
@@ -298,7 +298,7 @@ static int bpa10x_send_frame(struct hci_dev *hdev, struct sk_buff *skb) 


	switch (hci_skb_pkt_type(skb)) {

	case HCI_COMMAND_PKT:

		dr = kmalloc(sizeof(*dr), GFP_ATOMIC);

		dr = kmalloc(sizeof(*dr), GFP_KERNEL);

		if (!dr) {

			usb_free_urb(urb);

			return -ENOMEM;
@@ -343,7 +343,7 @@ static int bpa10x_send_frame(struct hci_dev *hdev, struct sk_buff *skb) 


	usb_anchor_urb(urb, &data->tx_anchor);



	err = usb_submit_urb(urb, GFP_ATOMIC);

	err = usb_submit_urb(urb, GFP_KERNEL);

	if (err < 0) {

		bt_dev_err(hdev, "urb %p submission failed", urb);

		kfree(urb->setup_packet);