Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43282ca8 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

drm/panfrost: Fix missing clk_disable_unprepare() on error in panfrost_clk_init() 



[ Upstream commit f42498705965bd4b026953c1892c686d8b1138e4 ]

Fix the missing clk_disable_unprepare() before return
from panfrost_clk_init() in the error handling case.

Fixes: b681af0b ("drm: panfrost: add optional bus_clock")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210608143856.4154766-1-weiyongjun1@huawei.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent fc9cf222

drivers/gpu/drm/panfrost/panfrost_device.c

+2 −1
Original line number Diff line number Diff line
@@ -59,7 +59,8 @@ static int panfrost_clk_init(struct panfrost_device *pfdev) 
	if (IS_ERR(pfdev->bus_clock)) {

		dev_err(pfdev->dev, "get bus_clock failed %ld\n",

			PTR_ERR(pfdev->bus_clock));

		return PTR_ERR(pfdev->bus_clock);

		err = PTR_ERR(pfdev->bus_clock);

		goto disable_clock;

	}



	if (pfdev->bus_clock) {