Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e843196 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda/sigmatel - Fix inverted mute LED 



While refactoring the mute-LED handling for HP laptops, I messed up
the polarity check in a wrong way.  The red (or the mute-LED if any)
should appear in the muted state, corresponding to GPIO on.

Reported-by: default avatarMikko Vinni <mmvinni@yahoo.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 118cb4a4

sound/pci/hda/patch_sigmatel.c

+2 −3
Original line number Diff line number Diff line
@@ -5063,12 +5063,11 @@ static void stac92xx_update_led_status(struct hda_codec *codec, int enabled) 
	if (spec->gpio_led_polarity)

		muted = !muted;



	/*polarity defines *not* muted state level*/

	if (!spec->vref_mute_led_nid) {

		if (muted)

			spec->gpio_data &= ~spec->gpio_led; /* orange */

			spec->gpio_data |= spec->gpio_led;

		else

			spec->gpio_data |= spec->gpio_led; /* white */

			spec->gpio_data &= ~spec->gpio_led;

		stac_gpio_set(codec, spec->gpio_mask,

				spec->gpio_dir, spec->gpio_data);

	} else {