Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 118cb4a4 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda/realtek - Fix regression on Quanta/Gericom KN1 



Through the transition to the auto-parser, the support for
Quanta/Gericom KN1 got broken.  There are two problems behind it:

- This machine doesn't like the default COEF setup for ALC260 we take
  now as default

- BIOS doesn't set the pins correctly at all; especially the machine
  uses only the pin 0x0f for both headphone and speaker

This patch adds the fixup as a workaround for these issues.

Reported-and-tested-by: default avatarUros Vampl <mobile.leecher@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f2ec52d4

sound/pci/hda/patch_realtek.c

+45 −4
Original line number Diff line number Diff line
@@ -1445,6 +1445,13 @@ enum { 
	ALC_FIXUP_ACT_BUILD,

};



static void alc_apply_pincfgs(struct hda_codec *codec,

			      const struct alc_pincfg *cfg)

{

	for (; cfg->nid; cfg++)

		snd_hda_codec_set_pincfg(codec, cfg->nid, cfg->val);

}



static void alc_apply_fixup(struct hda_codec *codec, int action)

{

	struct alc_spec *spec = codec->spec;
@@ -1478,9 +1485,7 @@ static void alc_apply_fixup(struct hda_codec *codec, int action) 
			snd_printdd(KERN_INFO "hda_codec: %s: "

				    "Apply pincfg for %s\n",

				    codec->chip_name, modelname);

			for (; cfg->nid; cfg++)

				snd_hda_codec_set_pincfg(codec, cfg->nid,

							 cfg->val);

			alc_apply_pincfgs(codec, cfg);

			break;

		case ALC_FIXUP_VERBS:

			if (action != ALC_FIXUP_ACT_PROBE || !fix->v.verbs)
@@ -4861,6 +4866,7 @@ enum { 
	ALC260_FIXUP_GPIO1_TOGGLE,

	ALC260_FIXUP_REPLACER,

	ALC260_FIXUP_HP_B1900,

	ALC260_FIXUP_KN1,

};



static void alc260_gpio1_automute(struct hda_codec *codec)
@@ -4888,6 +4894,36 @@ static void alc260_fixup_gpio1_toggle(struct hda_codec *codec, 
	}

}



static void alc260_fixup_kn1(struct hda_codec *codec,

			     const struct alc_fixup *fix, int action)

{

	struct alc_spec *spec = codec->spec;

	static const struct alc_pincfg pincfgs[] = {

		{ 0x0f, 0x02214000 }, /* HP/speaker */

		{ 0x12, 0x90a60160 }, /* int mic */

		{ 0x13, 0x02a19000 }, /* ext mic */

		{ 0x18, 0x01446000 }, /* SPDIF out */

		/* disable bogus I/O pins */

		{ 0x10, 0x411111f0 },

		{ 0x11, 0x411111f0 },

		{ 0x14, 0x411111f0 },

		{ 0x15, 0x411111f0 },

		{ 0x16, 0x411111f0 },

		{ 0x17, 0x411111f0 },

		{ 0x19, 0x411111f0 },

		{ }

	};



	switch (action) {

	case ALC_FIXUP_ACT_PRE_PROBE:

		alc_apply_pincfgs(codec, pincfgs);

		break;

	case ALC_FIXUP_ACT_PROBE:

		spec->init_amp = ALC_INIT_NONE;

		break;

	}

}



static const struct alc_fixup alc260_fixups[] = {

	[ALC260_FIXUP_HP_DC5750] = {

		.type = ALC_FIXUP_PINS,
@@ -4938,7 +4974,11 @@ static const struct alc_fixup alc260_fixups[] = { 
		.v.func = alc260_fixup_gpio1_toggle,

		.chained = true,

		.chain_id = ALC260_FIXUP_COEF,

	}

	},

	[ALC260_FIXUP_KN1] = {

		.type = ALC_FIXUP_FUNC,

		.v.func = alc260_fixup_kn1,

	},

};



static const struct snd_pci_quirk alc260_fixup_tbl[] = {
@@ -4948,6 +4988,7 @@ static const struct snd_pci_quirk alc260_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x280a, "HP dc5750", ALC260_FIXUP_HP_DC5750),

	SND_PCI_QUIRK(0x103c, 0x30ba, "HP Presario B1900", ALC260_FIXUP_HP_B1900),

	SND_PCI_QUIRK(0x1509, 0x4540, "Favorit 100XS", ALC260_FIXUP_GPIO1),

	SND_PCI_QUIRK(0x152d, 0x0729, "Quanta KN1", ALC260_FIXUP_KN1),

	SND_PCI_QUIRK(0x161f, 0x2057, "Replacer 672V", ALC260_FIXUP_REPLACER),

	SND_PCI_QUIRK(0x1631, 0xc017, "PB V7900", ALC260_FIXUP_COEF),

	{}