Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e699473 authored by Schspa Shi's avatar Schspa Shi Committed by Greg Kroah-Hartman
Browse files

vfio: Clear the caps->buf to NULL after free 



[ Upstream commit 6641085e8d7b3f061911517f79a2a15a0a21b97b ]

On buffer resize failure, vfio_info_cap_add() will free the buffer,
report zero for the size, and return -ENOMEM.  As additional
hardening, also clear the buffer pointer to prevent any chance of a
double free.

Signed-off-by: default avatarSchspa Shi <schspa@gmail.com>
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
Link: https://lore.kernel.org/r/20220629022948.55608-1-schspa@gmail.com


Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ca3fc1c3

drivers/vfio/vfio.c

+1 −0
Original line number Diff line number Diff line
@@ -1802,6 +1802,7 @@ struct vfio_info_cap_header *vfio_info_cap_add(struct vfio_info_cap *caps, 
	buf = krealloc(caps->buf, caps->size + size, GFP_KERNEL);

	if (!buf) {

		kfree(caps->buf);

		caps->buf = NULL;

		caps->size = 0;

		return ERR_PTR(-ENOMEM);

	}