Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca3fc1c3 authored by Liang He's avatar Liang He Committed by Greg Kroah-Hartman
Browse files

tty: serial: Fix refcount leak bug in ucc_uart.c 



[ Upstream commit d24d7bb2cd947676f9b71fb944d045e09b8b282f ]

In soc_info(), of_find_node_by_type() will return a node pointer
with refcount incremented. We should use of_node_put() when it is
not used anymore.

Acked-by: default avatarTimur Tabi <timur@kernel.org>
Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220618060850.4058525-1-windhl@126.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3c0efcd6

drivers/tty/serial/ucc_uart.c

+2 −0
Original line number Diff line number Diff line
@@ -1141,6 +1141,8 @@ static unsigned int soc_info(unsigned int *rev_h, unsigned int *rev_l) 
		/* No compatible property, so try the name. */

		soc_string = np->name;



	of_node_put(np);



	/* Extract the SOC number from the "PowerPC," string */

	if ((sscanf(soc_string, "PowerPC,%u", &soc) != 1) || !soc)

		return 0;