Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dc0a548 authored by wangweidong's avatar wangweidong Committed by David S. Miller
Browse files

sctp: remove the repeat initialize with 0 



kmem_cache_zalloc had set the allocated memory to zero. I think no need
to initialize with 0. And move the comments to the function begin.

Acked-by: default avatarVlad Yasevich <vyasevich@gmail.com>
Signed-off-by: default avatarWang Weidong <wangweidong1@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2bccbadf

net/sctp/sm_make_chunk.c

+8 −21
Original line number Original line Diff line number Diff line
@@ -1297,6 +1297,13 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc) 




/* Turn an skb into a chunk.

/* Turn an skb into a chunk.

 * FIXME: Eventually move the structure directly inside the skb->cb[].

 * FIXME: Eventually move the structure directly inside the skb->cb[].

 *

 * sctpimpguide-05.txt Section 2.8.2

 * M1) Each time a new DATA chunk is transmitted

 * set the 'TSN.Missing.Report' count for that TSN to 0. The

 * 'TSN.Missing.Report' count will be used to determine missing chunks

 * and when to fast retransmit.

 *

 */

 */

struct sctp_chunk *sctp_chunkify(struct sk_buff *skb,

struct sctp_chunk *sctp_chunkify(struct sk_buff *skb,

			    const struct sctp_association *asoc,

			    const struct sctp_association *asoc,
@@ -1314,30 +1321,10 @@ struct sctp_chunk *sctp_chunkify(struct sk_buff *skb, 
	INIT_LIST_HEAD(&retval->list);

	INIT_LIST_HEAD(&retval->list);

	retval->skb		= skb;

	retval->skb		= skb;

	retval->asoc		= (struct sctp_association *)asoc;

	retval->asoc		= (struct sctp_association *)asoc;

	retval->has_tsn		= 0;

	retval->has_ssn         = 0;

	retval->rtt_in_progress	= 0;

	retval->sent_at		= 0;

	retval->singleton	= 1;

	retval->singleton	= 1;

	retval->end_of_packet	= 0;

	retval->ecn_ce_done	= 0;

	retval->pdiscard	= 0;





	/* sctpimpguide-05.txt Section 2.8.2

	 * M1) Each time a new DATA chunk is transmitted

	 * set the 'TSN.Missing.Report' count for that TSN to 0. The

	 * 'TSN.Missing.Report' count will be used to determine missing chunks

	 * and when to fast retransmit.

	 */

	retval->tsn_missing_report = 0;

	retval->tsn_gap_acked = 0;

	retval->fast_retransmit = SCTP_CAN_FRTX;

	retval->fast_retransmit = SCTP_CAN_FRTX;





	/* If this is a fragmented message, track all fragments

	 * of the message (for SEND_FAILED).

	 */

	retval->msg = NULL;



	/* Polish the bead hole.  */

	/* Polish the bead hole.  */

	INIT_LIST_HEAD(&retval->transmitted_list);

	INIT_LIST_HEAD(&retval->transmitted_list);

	INIT_LIST_HEAD(&retval->frag_list);

	INIT_LIST_HEAD(&retval->frag_list);