Commit 34b3be18 authored Sep 25, 2019 by Navid Emamdoost Committed by Jason Gunthorpe Oct 01, 2019

RDMA/hfi1: Prevent memory leak in sdma_init

In sdma_init if rhashtable_init fails the allocated memory for
tmp_sdma_rht should be released.

Fixes: 5a52a7ac ("IB/hfi1: NULL pointer dereference when freeing rhashtable")
Link: https://lore.kernel.org/r/20190925144543.10141-1-navid.emamdoost@gmail.com


Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 390d3fdc

drivers/infiniband/hw/hfi1/sdma.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1526,8 +1526,11 @@ int sdma_init(struct hfi1_devdata *dd, u8 port)
		}

		ret = rhashtable_init(tmp_sdma_rht, &sdma_rht_params);
		if (ret < 0)
		if (ret < 0) {
		kfree(tmp_sdma_rht);
		goto bail;
		}

		dd->sdma_rht = tmp_sdma_rht;

		dd_dev_info(dd, "SDMA num_sdma: %u\n", dd->num_sdma);