Commit 390d3fdc authored Sep 25, 2019 by Michal Kalderon Committed by Jason Gunthorpe Oct 01, 2019

RDMA/core: Fix use after free and refcnt leak on ndev in_device in iwarp_query_port

If an iWARP driver is probed and removed while there are no ips set for
the device, it will lead to a reference count leak on the inet device of
the netdevice.

In addition, the netdevice was accessed after already calling netdev_put,
which could lead to using the netdev after already freed.

Fixes: 4929116b ("RDMA/core: Add common iWARP query port")
Link: https://lore.kernel.org/r/20190925123332.10746-1-michal.kalderon@marvell.com


Signed-off-by: Ariel Elior <ariel.elior@marvell.com>
Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
Reviewed-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent df791c54

drivers/infiniband/core/device.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -1987,8 +1987,6 @@ static int iw_query_port(struct ib_device *device,
		if (!netdev)
		return -ENODEV;

		dev_put(netdev);

		port_attr->max_mtu = IB_MTU_4096;
		port_attr->active_mtu = ib_mtu_int_to_enum(netdev->mtu);

		@@ -1996,19 +1994,22 @@ static int iw_query_port(struct ib_device *device,
		port_attr->state = IB_PORT_DOWN;
		port_attr->phys_state = IB_PORT_PHYS_STATE_DISABLED;
		} else {
		inetdev = in_dev_get(netdev);
		rcu_read_lock();
		inetdev = __in_dev_get_rcu(netdev);

		if (inetdev && inetdev->ifa_list) {
		port_attr->state = IB_PORT_ACTIVE;
		port_attr->phys_state = IB_PORT_PHYS_STATE_LINK_UP;
		in_dev_put(inetdev);
		} else {
		port_attr->state = IB_PORT_INIT;
		port_attr->phys_state =
		IB_PORT_PHYS_STATE_PORT_CONFIGURATION_TRAINING;
		}

		rcu_read_unlock();
		}

		dev_put(netdev);
		err = device->ops.query_port(device, port_num, port_attr);
		if (err)
		return err;