Commit 321f3837 authored May 29, 2023 by Peilin Ye Committed by Greg Kroah-Hartman Jun 09, 2023

net/sched: sch_clsact: Only create under TC_H_CLSACT



[ Upstream commit 5eeebfe6c493192b10d516abfd72742900f2a162 ]

clsact Qdiscs are only supposed to be created under TC_H_CLSACT (which
equals TC_H_INGRESS).  Return -EOPNOTSUPP if 'parent' is not
TC_H_CLSACT.

Fixes: 1f211a1b ("net, sched: add clsact qdisc")
Tested-by: Pedro Tammela <pctammela@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5f67d33c

net/sched/sch_ingress.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -218,6 +218,9 @@ static int clsact_init(struct Qdisc sch, struct nlattr opt,
		struct net_device *dev = qdisc_dev(sch);
		int err;

		if (sch->parent != TC_H_CLSACT)
		return -EOPNOTSUPP;

		net_inc_ingress_queue();
		net_inc_egress_queue();

		@@ -245,6 +248,9 @@ static void clsact_destroy(struct Qdisc *sch)
		{
		struct clsact_sched_data *q = qdisc_priv(sch);

		if (sch->parent != TC_H_CLSACT)
		return;

		tcf_block_put_ext(q->egress_block, sch, &q->egress_block_info);
		tcf_block_put_ext(q->ingress_block, sch, &q->ingress_block_info);