Commit 5f67d33c authored May 29, 2023 by Peilin Ye Committed by Greg Kroah-Hartman Jun 09, 2023

net/sched: sch_ingress: Only create under TC_H_INGRESS



[ Upstream commit c7cfbd115001f94de9e4053657946a383147e803 ]

ingress Qdiscs are only supposed to be created under TC_H_INGRESS.
Return -EOPNOTSUPP if 'parent' is not TC_H_INGRESS, similar to
mq_init().

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Reported-by:  <syzbot+b53a9c0d1ea4ad62da8b@syzkaller.appspotmail.com>
Closes: https://lore.kernel.org/r/0000000000006cf87705f79acf1a@google.com/


Tested-by: Pedro Tammela <pctammela@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 381a7032

net/sched/sch_ingress.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -79,6 +79,9 @@ static int ingress_init(struct Qdisc sch, struct nlattr opt,
		struct ingress_sched_data *q = qdisc_priv(sch);
		struct net_device *dev = qdisc_dev(sch);

		if (sch->parent != TC_H_INGRESS)
		return -EOPNOTSUPP;

		net_inc_ingress_queue();

		mini_qdisc_pair_init(&q->miniqp, sch, &dev->miniq_ingress);
		@@ -94,6 +97,9 @@ static void ingress_destroy(struct Qdisc *sch)
		{
		struct ingress_sched_data *q = qdisc_priv(sch);

		if (sch->parent != TC_H_INGRESS)
		return;

		tcf_block_put_ext(q->block, sch, &q->block_info);
		net_dec_ingress_queue();
		}