Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3200cf7b authored by Julian Braha's avatar Julian Braha Committed by Greg Kroah-Hartman
Browse files

drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY 



[ Upstream commit bb162bb2b4394108c8f055d1b115735331205e28 ]

When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER
is not selected, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY
  Depends on [n]: (ARCH_SUNXI [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=n]
  Selected by [y]:
  - DRM_SUN6I_DSI [=y] && HAS_IOMEM [=y] && DRM_SUN4I [=y]

This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY
without selecting or depending on RESET_CONTROLLER, despite
PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER.

These unmet dependency bugs were detected by Kismet,
a static analysis tool for Kconfig. Please advise if this
is not the appropriate solution.

v2:
Fixed indentation to match the rest of the file.

Signed-off-by: default avatarJulian Braha <julianbraha@gmail.com>
Acked-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20211109032351.43322-1-julianbraha@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7ef99036

drivers/gpu/drm/sun4i/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ config DRM_SUN6I_DSI 
	default MACH_SUN8I

	select CRC_CCITT

	select DRM_MIPI_DSI

	select RESET_CONTROLLER

	select PHY_SUN6I_MIPI_DPHY

	help

	  Choose this option if you want have an Allwinner SoC with