Commit 7ef99036 authored Nov 06, 2021 by Andreas Gruenbacher Committed by Greg Kroah-Hartman Dec 08, 2021

gfs2: Fix length of holes reported at end-of-file



[ Upstream commit f3506eee81d1f700d9ee2d2f4a88fddb669ec032 ]

Fix the length of holes reported at the end of a file: the length is
relative to the beginning of the extent, not the seek position which is
rounded down to the filesystem block size.

This bug went unnoticed for some time, but is now caught by the
following assertion in iomap_iter_done():

  WARN_ON_ONCE(iter->iomap.offset + iter->iomap.length <= iter->pos)

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fe915dbd

fs/gfs2/bmap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -940,7 +940,7 @@ static int gfs2_iomap_get(struct inode *inode, loff_t pos, loff_t length,
		else if (height == ip->i_height)
		ret = gfs2_hole_size(inode, lblock, len, mp, iomap);
		else
		iomap->length = size - pos;
		iomap->length = size - iomap->offset;
		} else if (flags & IOMAP_WRITE) {
		u64 alloc_size;