Commit 2f6451ed authored Aug 17, 2019 by Wenwen Wang Committed by Mauro Carvalho Chehab Aug 21, 2019

media: dvb-frontends: fix a memory leak bug



In cx24117_load_firmware(), 'buf' is allocated through kmalloc() to hold
the firmware. However, if i2c_transfer() fails, it is not deallocated,
leading to a memory leak bug.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 8c3d3cdb

drivers/media/dvb-frontends/cx24117.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -619,8 +619,10 @@ static int cx24117_load_firmware(struct dvb_frontend *fe,

		/* send fw */
		ret = i2c_transfer(state->priv->i2c, &msg, 1);
		if (ret < 0)
		if (ret < 0) {
		kfree(buf);
		return ret;
		}

		kfree(buf);