Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c3d3cdb authored by Wenwen Wang's avatar Wenwen Wang Committed by Mauro Carvalho Chehab
Browse files

media: dvb-frontends: fix memory leaks 



In dib7000pc_detection(), 'tx' and 'rx' are allocated through kzalloc()
respectively. However, if DiB7000PC is detected, they are not deallocated,
leading to memory leaks. To fix this issue, create a label to free 'tx' and
'rx' before returning from the function.

Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 9fc3ce31

drivers/media/dvb-frontends/dib7000p.c

+5 −2
Original line number Diff line number Diff line
@@ -2036,7 +2036,8 @@ static int dib7000pc_detection(struct i2c_adapter *i2c_adap) 
	if (i2c_transfer(i2c_adap, msg, 2) == 2)

		if (rx[0] == 0x01 && rx[1] == 0xb3) {

			dprintk("-D-  DiB7000PC detected\n");

			return 1;

			ret = 1;

			goto out;

		}



	msg[0].addr = msg[1].addr = 0x40;
@@ -2044,11 +2045,13 @@ static int dib7000pc_detection(struct i2c_adapter *i2c_adap) 
	if (i2c_transfer(i2c_adap, msg, 2) == 2)

		if (rx[0] == 0x01 && rx[1] == 0xb3) {

			dprintk("-D-  DiB7000PC detected\n");

			return 1;

			ret = 1;

			goto out;

		}



	dprintk("-D-  DiB7000PC not detected\n");



out:

	kfree(rx);

rx_memory_error:

	kfree(tx);